Index: ChangeLog =================================================================== --- ChangeLog (revision 22322) +++ ChangeLog (working copy) @@ -1,3 +1,38 @@ +2007-04-25 Michael Natterer + + * app/core/gimpparamspecs.[ch] (struct GimpParamSpecString) + (gimp_param_spec_string): added "gboolean non_empty" to require + the string being non-empty. Changed validation accordingly. + + * app/xcf/xcf.c: filenames should be non-empty. + * app/pdb/gimp-pdb-compat.c: compat strings shouldn't. + + * tools/pdbgen/app.pl: add support for $arg->{non_empty} and + changed generation of calls to gimp_param_spec_string(). + + * tools/pdbgen/pdb/brush_select.pdb + * tools/pdbgen/pdb/edit.pdb + * tools/pdbgen/pdb/vectors.pdb + * tools/pdbgen/pdb/plug_in.pdb + * tools/pdbgen/pdb/gradient.pdb + * tools/pdbgen/pdb/palette_select.pdb + * tools/pdbgen/pdb/palette.pdb + * tools/pdbgen/pdb/fileops.pdb + * tools/pdbgen/pdb/progress.pdb + * tools/pdbgen/pdb/procedural_db.pdb + * tools/pdbgen/pdb/font_select.pdb + * tools/pdbgen/pdb/pattern_select.pdb + * tools/pdbgen/pdb/unit.pdb + * tools/pdbgen/pdb/brush.pdb + * tools/pdbgen/pdb/gradient_select.pdb + * tools/pdbgen/pdb/buffer.pdb: require non-empty strings for data + object names, procedure names, unit strings, PDB data identifiers + and buffer names. Removed some manual strlen() checks, all other + places just got better error reporting for free (proper validation + error instead of unspecific execution error). + + * app/pdb/*_cmds.c: regenerated. + 2007-04-25 Sven Neumann * app/paint-funcs/paint-funcs.c (convolve_region): round pixel values Index: app/core/gimpparamspecs.c =================================================================== --- app/core/gimpparamspecs.c (revision 22322) +++ app/core/gimpparamspecs.c (working copy) @@ -351,6 +351,7 @@ gimp_param_string_init (GParamSpec *pspe sspec->no_validate = FALSE; sspec->null_ok = FALSE; + sspec->non_empty = FALSE; } static gboolean @@ -364,10 +365,28 @@ gimp_param_string_validate (GParamSpec * { gchar *s; + if (sspec->non_empty && ! string[0]) + { + if (!(value->data[1].v_uint & G_VALUE_NOCOPY_CONTENTS)) + g_free (string); + else + value->data[1].v_uint &= ~G_VALUE_NOCOPY_CONTENTS; + + value->data[0].v_pointer = g_strdup ("none"); + return TRUE; + } + if (! sspec->no_validate && ! g_utf8_validate (string, -1, (const gchar **) &s)) { - for (; *s; s++) + if (value->data[1].v_uint & G_VALUE_NOCOPY_CONTENTS) + { + value->data[0].v_pointer = g_strdup (string); + value->data[1].v_uint &= ~G_VALUE_NOCOPY_CONTENTS; + string = value->data[0].v_pointer; + } + + for (s = string; *s; s++) if (*s < ' ') *s = '?'; @@ -376,9 +395,16 @@ gimp_param_string_validate (GParamSpec * } else if (! sspec->null_ok) { + value->data[1].v_uint &= ~G_VALUE_NOCOPY_CONTENTS; value->data[0].v_pointer = g_strdup (""); return TRUE; } + else if (sspec->non_empty) + { + value->data[1].v_uint &= ~G_VALUE_NOCOPY_CONTENTS; + value->data[0].v_pointer = g_strdup ("none"); + return TRUE; + } return FALSE; } @@ -389,11 +415,14 @@ gimp_param_spec_string (const gchar *nam const gchar *blurb, gboolean no_validate, gboolean null_ok, + gboolean non_empty, const gchar *default_value, GParamFlags flags) { GimpParamSpecString *sspec; + g_return_val_if_fail (! (null_ok && non_empty), NULL); + sspec = g_param_spec_internal (GIMP_TYPE_PARAM_STRING, name, nick, blurb, flags); @@ -404,6 +433,7 @@ gimp_param_spec_string (const gchar *nam sspec->no_validate = no_validate ? TRUE : FALSE; sspec->null_ok = null_ok ? TRUE : FALSE; + sspec->non_empty = non_empty ? TRUE : FALSE; } return G_PARAM_SPEC (sspec); Index: app/core/gimpparamspecs.h =================================================================== --- app/core/gimpparamspecs.h (revision 22322) +++ app/core/gimpparamspecs.h (working copy) @@ -153,6 +153,7 @@ struct _GimpParamSpecString guint no_validate : 1; guint null_ok : 1; + guint non_empty : 1; }; GType gimp_param_string_get_type (void) G_GNUC_CONST; @@ -162,6 +163,7 @@ GParamSpec * gimp_param_spec_string const gchar *blurb, gboolean no_validate, gboolean null_ok, + gboolean non_empty, const gchar *default_value, GParamFlags flags); Index: app/xcf/xcf.c =================================================================== --- app/xcf/xcf.c (revision 22322) +++ app/xcf/xcf.c (working copy) @@ -141,14 +141,16 @@ xcf_init (Gimp *gimp) "in the on-disk " "character set and " "encoding", - TRUE, FALSE, NULL, + TRUE, FALSE, TRUE, + NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("raw-filename", "Raw filename", "The basename of the " "file, in UTF-8", - FALSE, FALSE, NULL, + FALSE, FALSE, TRUE, + NULL, GIMP_PARAM_READWRITE)); gimp_plug_in_manager_add_procedure (gimp->plug_in_manager, proc); g_object_unref (procedure); @@ -195,14 +197,16 @@ xcf_init (Gimp *gimp) "to load, in the " "on-disk character " "set and encoding", - TRUE, FALSE, NULL, + TRUE, FALSE, TRUE, + NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("raw-filename", "Raw filename", "The basename of the " "file, in UTF-8", - FALSE, FALSE, NULL, + FALSE, FALSE, TRUE, + NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, Index: app/pdb/help_cmds.c =================================================================== --- app/pdb/help_cmds.c (revision 22322) +++ app/pdb/help_cmds.c (working copy) @@ -88,14 +88,14 @@ register_help_procs (GimpPDB *pdb) gimp_param_spec_string ("help-domain", "help domain", "The help domain in which help_id is registered", - FALSE, TRUE, + FALSE, TRUE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("help-id", "help id", "The help page's ID", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); Index: app/pdb/fonts_cmds.c =================================================================== --- app/pdb/fonts_cmds.c (revision 22322) +++ app/pdb/fonts_cmds.c (working copy) @@ -117,7 +117,7 @@ register_fonts_procs (GimpPDB *pdb) gimp_param_spec_string ("filter", "filter", "An optional regular expression used to filter the list", - FALSE, TRUE, + FALSE, TRUE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, Index: app/pdb/palette_cmds.c =================================================================== --- app/pdb/palette_cmds.c (revision 22322) +++ app/pdb/palette_cmds.c (working copy) @@ -56,15 +56,10 @@ palette_new_invoker (GimpProcedure * if (success) { - if (strlen (name)) - { - GimpData *data = gimp_data_factory_data_new (gimp->palette_factory, name); + GimpData *data = gimp_data_factory_data_new (gimp->palette_factory, name); - if (data) - actual_name = g_strdup (gimp_object_get_name (GIMP_OBJECT (data))); - else - success = FALSE; - } + if (data) + actual_name = g_strdup (gimp_object_get_name (GIMP_OBJECT (data))); else success = FALSE; } @@ -140,7 +135,7 @@ palette_rename_invoker (GimpProcedure GimpPalette *palette = (GimpPalette *) gimp_container_get_child_by_name (gimp->palette_factory->container, name); - if (palette && GIMP_DATA (palette)->writable && strlen (new_name)) + if (palette && GIMP_DATA (palette)->writable) { gimp_object_set_name (GIMP_OBJECT (palette), new_name); actual_name = g_strdup (gimp_object_get_name (GIMP_OBJECT (palette))); @@ -595,14 +590,14 @@ register_palette_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The requested name of the new palette", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, gimp_param_spec_string ("actual-name", "actual name", "The actual new palette name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -625,14 +620,14 @@ register_palette_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The palette name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, gimp_param_spec_string ("copy-name", "copy name", "The name of the palette's copy", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -655,21 +650,21 @@ register_palette_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The palette name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("new-name", "new name", "The new name of the palette", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, gimp_param_spec_string ("actual-name", "actual name", "The actual new name of the palette", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -692,7 +687,7 @@ register_palette_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The palette name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -715,7 +710,7 @@ register_palette_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The palette name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, @@ -744,7 +739,7 @@ register_palette_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The palette name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, @@ -773,7 +768,7 @@ register_palette_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The palette name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, @@ -802,7 +797,7 @@ register_palette_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The palette name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -831,14 +826,14 @@ register_palette_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The palette name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("entry-name", "entry name", "The name of the entry", - FALSE, TRUE, + FALSE, TRUE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -874,7 +869,7 @@ register_palette_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The palette name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -903,7 +898,7 @@ register_palette_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The palette name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -939,7 +934,7 @@ register_palette_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The palette name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -975,7 +970,7 @@ register_palette_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The palette name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -988,7 +983,7 @@ register_palette_procs (GimpPDB *pdb) gimp_param_spec_string ("entry-name", "entry name", "The name requested", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -1011,7 +1006,7 @@ register_palette_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The palette name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -1024,7 +1019,7 @@ register_palette_procs (GimpPDB *pdb) gimp_param_spec_string ("entry-name", "entry name", "The new name", - FALSE, TRUE, + FALSE, TRUE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); Index: app/pdb/progress_cmds.c =================================================================== --- app/pdb/progress_cmds.c (revision 22322) +++ app/pdb/progress_cmds.c (working copy) @@ -269,7 +269,7 @@ register_progress_procs (GimpPDB *pdb) gimp_param_spec_string ("message", "message", "Message to use in the progress dialog", - FALSE, TRUE, + FALSE, TRUE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -336,7 +336,7 @@ register_progress_procs (GimpPDB *pdb) gimp_param_spec_string ("message", "message", "Message to use in the progress dialog", - FALSE, TRUE, + FALSE, TRUE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -381,7 +381,7 @@ register_progress_procs (GimpPDB *pdb) gimp_param_spec_string ("progress-callback", "progress callback", "The callback PDB proc to call", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -404,7 +404,7 @@ register_progress_procs (GimpPDB *pdb) gimp_param_spec_string ("progress-callback", "progress callback", "The name of the callback registered for this progress", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -427,7 +427,7 @@ register_progress_procs (GimpPDB *pdb) gimp_param_spec_string ("progress-callback", "progress callback", "The name of the callback registered for this progress", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); Index: app/pdb/channel_cmds.c =================================================================== --- app/pdb/channel_cmds.c (revision 22322) +++ app/pdb/channel_cmds.c (working copy) @@ -370,7 +370,7 @@ register_channel_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The channel name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -425,7 +425,7 @@ register_channel_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The channel name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, Index: app/pdb/parasite_cmds.c =================================================================== --- app/pdb/parasite_cmds.c (revision 22322) +++ app/pdb/parasite_cmds.c (working copy) @@ -474,7 +474,7 @@ register_parasite_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The name of the parasite to find", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, @@ -523,7 +523,7 @@ register_parasite_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The name of the parasite to detach.", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -579,7 +579,7 @@ register_parasite_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The name of the parasite to find", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, @@ -640,7 +640,7 @@ register_parasite_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The name of the parasite to detach from an image.", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -702,7 +702,7 @@ register_parasite_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The name of the parasite to find", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, @@ -763,7 +763,7 @@ register_parasite_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The name of the parasite to detach from a drawable.", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -825,7 +825,7 @@ register_parasite_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The name of the parasite to find", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, @@ -886,7 +886,7 @@ register_parasite_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The name of the parasite to detach from a vectors object.", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); Index: app/pdb/buffer_cmds.c =================================================================== --- app/pdb/buffer_cmds.c (revision 22322) +++ app/pdb/buffer_cmds.c (working copy) @@ -91,7 +91,7 @@ buffer_rename_invoker (GimpProcedure GimpBuffer *buffer = (GimpBuffer *) gimp_container_get_child_by_name (gimp->named_buffers, buffer_name); - if (buffer && strlen (new_name)) + if (buffer) { gimp_object_set_name (GIMP_OBJECT (buffer), new_name); real_name = g_strdup (gimp_object_get_name (GIMP_OBJECT (buffer))); @@ -288,7 +288,7 @@ register_buffer_procs (GimpPDB *pdb) gimp_param_spec_string ("filter", "filter", "An optional regular expression used to filter the list", - FALSE, TRUE, + FALSE, TRUE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, @@ -322,21 +322,21 @@ register_buffer_procs (GimpPDB *pdb) gimp_param_spec_string ("buffer-name", "buffer name", "The buffer name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("new-name", "new name", "The buffer's new name", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, gimp_param_spec_string ("real-name", "real name", "The real name given to the buffer", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -359,7 +359,7 @@ register_buffer_procs (GimpPDB *pdb) gimp_param_spec_string ("buffer-name", "buffer name", "The buffer name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -382,7 +382,7 @@ register_buffer_procs (GimpPDB *pdb) gimp_param_spec_string ("buffer-name", "buffer name", "The buffer name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, @@ -411,7 +411,7 @@ register_buffer_procs (GimpPDB *pdb) gimp_param_spec_string ("buffer-name", "buffer name", "The buffer name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, @@ -440,7 +440,7 @@ register_buffer_procs (GimpPDB *pdb) gimp_param_spec_string ("buffer-name", "buffer name", "The buffer name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, @@ -469,7 +469,7 @@ register_buffer_procs (GimpPDB *pdb) gimp_param_spec_string ("buffer-name", "buffer name", "The buffer name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, Index: app/pdb/gimp-pdb-compat.c =================================================================== --- app/pdb/gimp-pdb-compat.c (revision 22322) +++ app/pdb/gimp-pdb-compat.c (working copy) @@ -73,7 +73,7 @@ gimp_pdb_compat_param_spec (Gimp case GIMP_PDB_STRING: pspec = gimp_param_spec_string (name, name, desc, - TRUE, TRUE, + TRUE, TRUE, FALSE, NULL, G_PARAM_READWRITE); break; Index: app/pdb/pattern_select_cmds.c =================================================================== --- app/pdb/pattern_select_cmds.c (revision 22322) +++ app/pdb/pattern_select_cmds.c (working copy) @@ -137,21 +137,21 @@ register_pattern_select_procs (GimpPDB * gimp_param_spec_string ("pattern-callback", "pattern callback", "The callback PDB proc to call when pattern selection is made", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("popup-title", "popup title", "Title of the pattern selection dialog", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("initial-pattern", "initial pattern", "The name of the pattern to set as the first selected", - FALSE, TRUE, + FALSE, TRUE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -174,7 +174,7 @@ register_pattern_select_procs (GimpPDB * gimp_param_spec_string ("pattern-callback", "pattern callback", "The name of the callback registered for this pop-up", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -197,14 +197,14 @@ register_pattern_select_procs (GimpPDB * gimp_param_spec_string ("pattern-callback", "pattern callback", "The name of the callback registered for this pop-up", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("pattern-name", "pattern name", "The name of the pattern to set as selected", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); Index: app/pdb/pattern_cmds.c =================================================================== --- app/pdb/pattern_cmds.c (revision 22322) +++ app/pdb/pattern_cmds.c (working copy) @@ -155,7 +155,7 @@ register_pattern_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The pattern name.", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, @@ -196,7 +196,7 @@ register_pattern_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The pattern name.", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, Index: app/pdb/text_tool_cmds.c =================================================================== --- app/pdb/text_tool_cmds.c (revision 22322) +++ app/pdb/text_tool_cmds.c (working copy) @@ -320,7 +320,7 @@ register_text_tool_procs (GimpPDB *pdb) gimp_param_spec_string ("text", "text", "The text to generate (in UTF-8 encoding)", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -352,7 +352,7 @@ register_text_tool_procs (GimpPDB *pdb) gimp_param_spec_string ("fontname", "fontname", "The name of the font", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, @@ -381,7 +381,7 @@ register_text_tool_procs (GimpPDB *pdb) gimp_param_spec_string ("text", "text", "The text to generate (in UTF-8 encoding)", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -401,7 +401,7 @@ register_text_tool_procs (GimpPDB *pdb) gimp_param_spec_string ("fontname", "fontname", "The name of the font", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, @@ -472,7 +472,7 @@ register_text_tool_procs (GimpPDB *pdb) gimp_param_spec_string ("text", "text", "The text to generate (in UTF-8 encoding)", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -504,56 +504,56 @@ register_text_tool_procs (GimpPDB *pdb) gimp_param_spec_string ("foundry", "foundry", "The font foundry", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("family", "family", "The font family", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("weight", "weight", "The font weight", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("slant", "slant", "The font slant", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("set-width", "set width", "The font set-width", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("spacing", "spacing", "The font spacing", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("registry", "registry", "The font registry", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("encoding", "encoding", "The font encoding", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, @@ -582,7 +582,7 @@ register_text_tool_procs (GimpPDB *pdb) gimp_param_spec_string ("text", "text", "The text to generate (in UTF-8 encoding)", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -602,56 +602,56 @@ register_text_tool_procs (GimpPDB *pdb) gimp_param_spec_string ("foundry", "foundry", "The font foundry", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("family", "family", "The font family", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("weight", "weight", "The font weight", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("slant", "slant", "The font slant", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("set-width", "set width", "The font set-width", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("spacing", "spacing", "The font spacing", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("registry", "registry", "The font registry", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("encoding", "encoding", "The font encoding", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, Index: app/pdb/image_cmds.c =================================================================== --- app/pdb/image_cmds.c (revision 22322) +++ app/pdb/image_cmds.c (working copy) @@ -4325,7 +4325,7 @@ register_image_procs (GimpPDB *pdb) gimp_param_spec_string ("filename", "filename", "The filename", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -4354,7 +4354,7 @@ register_image_procs (GimpPDB *pdb) gimp_param_spec_string ("filename", "filename", "The new image filename", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -4383,7 +4383,7 @@ register_image_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); Index: app/pdb/message_cmds.c =================================================================== --- app/pdb/message_cmds.c (revision 22322) +++ app/pdb/message_cmds.c (working copy) @@ -122,7 +122,7 @@ register_message_procs (GimpPDB *pdb) gimp_param_spec_string ("message", "message", "Message to display in the dialog", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); Index: app/pdb/vectors_cmds.c =================================================================== --- app/pdb/vectors_cmds.c (revision 22322) +++ app/pdb/vectors_cmds.c (working copy) @@ -1307,7 +1307,7 @@ register_vectors_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "the name of the new vector object.", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, @@ -1370,7 +1370,7 @@ register_vectors_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The name of the vectors object", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -1399,7 +1399,7 @@ register_vectors_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "the new name of the path", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -2472,7 +2472,7 @@ register_vectors_procs (GimpPDB *pdb) gimp_param_spec_string ("filename", "filename", "The name of the SVG file to import.", - TRUE, FALSE, + TRUE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -2524,7 +2524,7 @@ register_vectors_procs (GimpPDB *pdb) gimp_param_spec_string ("string", "string", "A string that must be a complete and valid SVG document.", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, Index: app/pdb/edit_cmds.c =================================================================== --- app/pdb/edit_cmds.c (revision 22322) +++ app/pdb/edit_cmds.c (working copy) @@ -227,7 +227,7 @@ edit_named_cut_invoker (GimpProcedure if (success) { - if (strlen (buffer_name) && gimp_item_is_attached (GIMP_ITEM (drawable))) + if (gimp_item_is_attached (GIMP_ITEM (drawable))) { GimpImage *image = gimp_item_get_image (GIMP_ITEM (drawable)); @@ -269,7 +269,7 @@ edit_named_copy_invoker (GimpProcedure if (success) { - if (strlen (buffer_name) && gimp_item_is_attached (GIMP_ITEM (drawable))) + if (gimp_item_is_attached (GIMP_ITEM (drawable))) { GimpImage *image = gimp_item_get_image (GIMP_ITEM (drawable)); @@ -311,16 +311,11 @@ edit_named_copy_visible_invoker (GimpPro if (success) { - if (strlen (buffer_name)) - { - real_name = (gchar *) gimp_edit_named_copy_visible (image, buffer_name, - context); + real_name = (gchar *) gimp_edit_named_copy_visible (image, buffer_name, + context); - if (real_name) - real_name = g_strdup (real_name); - else - success = FALSE; - } + if (real_name) + real_name = g_strdup (real_name); else success = FALSE; } @@ -888,14 +883,14 @@ register_edit_procs (GimpPDB *pdb) gimp_param_spec_string ("buffer-name", "buffer name", "The name of the buffer to create", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, gimp_param_spec_string ("real-name", "real name", "The real name given to the buffer, or NULL if the selection contained only transparent pixels", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -924,14 +919,14 @@ register_edit_procs (GimpPDB *pdb) gimp_param_spec_string ("buffer-name", "buffer name", "The name of the buffer to create", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, gimp_param_spec_string ("real-name", "real name", "The real name given to the buffer, or NULL if the selection contained only transparent pixels", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -960,14 +955,14 @@ register_edit_procs (GimpPDB *pdb) gimp_param_spec_string ("buffer-name", "buffer name", "The name of the buffer to create", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, gimp_param_spec_string ("real-name", "real name", "The real name given to the buffer", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -996,7 +991,7 @@ register_edit_procs (GimpPDB *pdb) gimp_param_spec_string ("buffer-name", "buffer name", "The name of the buffer to paste", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -1031,7 +1026,7 @@ register_edit_procs (GimpPDB *pdb) gimp_param_spec_string ("buffer-name", "buffer name", "The name of the buffer to paste", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, Index: app/pdb/misc_cmds.c =================================================================== --- app/pdb/misc_cmds.c (revision 22322) +++ app/pdb/misc_cmds.c (working copy) @@ -125,7 +125,7 @@ register_misc_procs (GimpPDB *pdb) gimp_param_spec_string ("version", "version", "GIMP version number", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); Index: app/pdb/gradient_select_cmds.c =================================================================== --- app/pdb/gradient_select_cmds.c (revision 22322) +++ app/pdb/gradient_select_cmds.c (working copy) @@ -144,21 +144,21 @@ register_gradient_select_procs (GimpPDB gimp_param_spec_string ("gradient-callback", "gradient callback", "The callback PDB proc to call when gradient selection is made", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("popup-title", "popup title", "Title of the gradient selection dialog", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("initial-gradient", "initial gradient", "The name of the gradient to set as the first selected", - FALSE, TRUE, + FALSE, TRUE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -187,7 +187,7 @@ register_gradient_select_procs (GimpPDB gimp_param_spec_string ("gradient-callback", "gradient callback", "The name of the callback registered for this pop-up", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -210,14 +210,14 @@ register_gradient_select_procs (GimpPDB gimp_param_spec_string ("gradient-callback", "gradient callback", "The name of the callback registered for this pop-up", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("gradient-name", "gradient name", "The name of the gradient to set as selected", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); Index: app/pdb/palette_select_cmds.c =================================================================== --- app/pdb/palette_select_cmds.c (revision 22322) +++ app/pdb/palette_select_cmds.c (working copy) @@ -137,21 +137,21 @@ register_palette_select_procs (GimpPDB * gimp_param_spec_string ("palette-callback", "palette callback", "The callback PDB proc to call when palette selection is made", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("popup-title", "popup title", "Title of the palette selection dialog", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("initial-palette", "initial palette", "The name of the palette to set as the first selected", - FALSE, TRUE, + FALSE, TRUE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -174,7 +174,7 @@ register_palette_select_procs (GimpPDB * gimp_param_spec_string ("palette-callback", "palette callback", "The name of the callback registered for this pop-up", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -197,14 +197,14 @@ register_palette_select_procs (GimpPDB * gimp_param_spec_string ("palette-callback", "palette callback", "The name of the callback registered for this pop-up", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("palette-name", "palette name", "The name of the palette to set as selected", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); Index: app/pdb/gradient_cmds.c =================================================================== --- app/pdb/gradient_cmds.c (revision 22322) +++ app/pdb/gradient_cmds.c (working copy) @@ -105,15 +105,10 @@ gradient_new_invoker (GimpProcedure if (success) { - if (strlen (name)) - { - GimpData *data = gimp_data_factory_data_new (gimp->gradient_factory, name); + GimpData *data = gimp_data_factory_data_new (gimp->gradient_factory, name); - if (data) - actual_name = g_strdup (gimp_object_get_name (GIMP_OBJECT (data))); - else - success = FALSE; - } + if (data) + actual_name = g_strdup (gimp_object_get_name (GIMP_OBJECT (data))); else success = FALSE; } @@ -222,7 +217,7 @@ gradient_rename_invoker (GimpProcedure GimpGradient *gradient = (GimpGradient *) gimp_container_get_child_by_name (gimp->gradient_factory->container, name); - if (gradient && GIMP_DATA (gradient)->writable && strlen (new_name)) + if (gradient && GIMP_DATA (gradient)->writable) { gimp_object_set_name (GIMP_OBJECT (gradient), new_name); actual_name = g_strdup (gimp_object_get_name (GIMP_OBJECT (gradient))); @@ -1356,14 +1351,14 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The requested name of the new gradient", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, gimp_param_spec_string ("actual-name", "actual name", "The actual new gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -1386,14 +1381,14 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, gimp_param_spec_string ("copy-name", "copy name", "The name of the gradient's copy", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -1416,7 +1411,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, @@ -1445,21 +1440,21 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("new-name", "new name", "The new name of the gradient", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, gimp_param_spec_string ("actual-name", "actual name", "The actual new name of the gradient", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -1482,7 +1477,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -1505,7 +1500,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -1551,7 +1546,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -1602,7 +1597,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -1644,7 +1639,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -1686,7 +1681,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -1728,7 +1723,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -1770,7 +1765,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -1805,7 +1800,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -1846,7 +1841,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -1881,7 +1876,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -1922,7 +1917,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -1957,7 +1952,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -1998,7 +1993,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -2034,7 +2029,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -2070,7 +2065,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -2112,7 +2107,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -2154,7 +2149,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -2189,7 +2184,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -2230,7 +2225,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -2265,7 +2260,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -2306,7 +2301,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -2341,7 +2336,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -2376,7 +2371,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -2411,7 +2406,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, @@ -2446,7 +2441,7 @@ register_gradient_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The gradient name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, Index: app/pdb/plug_in_cmds.c =================================================================== --- app/pdb/plug_in_cmds.c (revision 22322) +++ app/pdb/plug_in_cmds.c (working copy) @@ -281,7 +281,7 @@ register_plug_in_procs (GimpPDB *pdb) gimp_param_spec_string ("search-string", "search string", "If not an empty string then use this as a search pattern", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE | GIMP_PARAM_NO_VALIDATE)); gimp_procedure_add_return_value (procedure, @@ -370,14 +370,14 @@ register_plug_in_procs (GimpPDB *pdb) gimp_param_spec_string ("domain-name", "domain name", "The name of the textdomain (must be unique)", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("domain-path", "domain path", "The absolute path to the compiled message catalog (may be NULL)", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE | GIMP_PARAM_NO_VALIDATE)); gimp_pdb_register_procedure (pdb, procedure); @@ -400,14 +400,14 @@ register_plug_in_procs (GimpPDB *pdb) gimp_param_spec_string ("domain-name", "domain name", "The XML namespace of the plug-in's help pages", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("domain-uri", "domain uri", "The root URI of the plug-in's help pages", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -430,14 +430,14 @@ register_plug_in_procs (GimpPDB *pdb) gimp_param_spec_string ("procedure-name", "procedure name", "The procedure for which to install the menu path", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("menu-path", "menu path", "The procedure's additional menu path", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -460,14 +460,14 @@ register_plug_in_procs (GimpPDB *pdb) gimp_param_spec_string ("menu-path", "menu path", "The sub-menu's menu path", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("menu-name", "menu name", "The name of the sub-menu", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -490,7 +490,7 @@ register_plug_in_procs (GimpPDB *pdb) gimp_param_spec_string ("procedure-name", "procedure name", "The procedure for which to install the icon", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, Index: app/pdb/patterns_cmds.c =================================================================== --- app/pdb/patterns_cmds.c (revision 22322) +++ app/pdb/patterns_cmds.c (working copy) @@ -220,7 +220,7 @@ register_patterns_procs (GimpPDB *pdb) gimp_param_spec_string ("filter", "filter", "An optional regular expression used to filter the list", - FALSE, TRUE, + FALSE, TRUE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, @@ -254,7 +254,7 @@ register_patterns_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The pattern name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, @@ -289,14 +289,14 @@ register_patterns_procs (GimpPDB *pdb) gimp_param_spec_string ("name", "name", "The pattern name (\"\" means currently active pattern)", - FALSE, TRUE, + FALSE, TRUE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, gimp_param_spec_string ("actual-name", "actual name", "The pattern name", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, Index: app/pdb/fileops_cmds.c =================================================================== --- app/pdb/fileops_cmds.c (revision 22322) +++ app/pdb/fileops_cmds.c (working copy) @@ -537,14 +537,14 @@ register_fileops_procs (GimpPDB *pdb) gimp_param_spec_string ("filename", "filename", "The name of the file to load", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("raw-filename", "raw filename", "The name as entered by the user", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, @@ -588,7 +588,7 @@ register_fileops_procs (GimpPDB *pdb) gimp_param_spec_string ("filename", "filename", "The name of the file to load", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, @@ -632,7 +632,7 @@ register_fileops_procs (GimpPDB *pdb) gimp_param_spec_string ("filename", "filename", "The name of the file to load", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, @@ -685,14 +685,14 @@ register_fileops_procs (GimpPDB *pdb) gimp_param_spec_string ("filename", "filename", "The name of the file to save the image in", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("raw-filename", "raw filename", "The name as entered by the user", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -715,7 +715,7 @@ register_fileops_procs (GimpPDB *pdb) gimp_param_spec_string ("filename", "filename", "The name of the file that owns the thumbnail to load", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, @@ -767,7 +767,7 @@ register_fileops_procs (GimpPDB *pdb) gimp_param_spec_string ("filename", "filename", "The name of the file the thumbnail belongs to", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -790,14 +790,14 @@ register_fileops_procs (GimpPDB *pdb) gimp_param_spec_string ("extension", "extension", "The extension the file will have", - TRUE, FALSE, + TRUE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_return_value (procedure, gimp_param_spec_string ("name", "name", "The new temp filename", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -820,28 +820,28 @@ register_fileops_procs (GimpPDB *pdb) gimp_param_spec_string ("procedure-name", "procedure name", "The name of the procedure to be used for loading", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("extensions", "extensions", "comma separated list of extensions this handler can load (i.e. \"jpg,jpeg\")", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE | GIMP_PARAM_NO_VALIDATE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("prefixes", "prefixes", "comma separated list of prefixes this handler can load (i.e. \"http:,ftp:\")", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE | GIMP_PARAM_NO_VALIDATE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("magics", "magics", "comma separated list of magic file information this handler can load (i.e. \"0,string,GIF\")", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE | GIMP_PARAM_NO_VALIDATE)); gimp_pdb_register_procedure (pdb, procedure); @@ -864,21 +864,21 @@ register_fileops_procs (GimpPDB *pdb) gimp_param_spec_string ("procedure-name", "procedure name", "The name of the procedure to be used for loading", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("extensions", "extensions", "comma separated list of extensions this handler can load (i.e. \"jpg,jpeg\")", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE | GIMP_PARAM_NO_VALIDATE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("prefixes", "prefixes", "comma separated list of prefixes this handler can load (i.e. \"http:,ftp:\")", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE | GIMP_PARAM_NO_VALIDATE)); gimp_pdb_register_procedure (pdb, procedure); @@ -901,21 +901,21 @@ register_fileops_procs (GimpPDB *pdb) gimp_param_spec_string ("procedure-name", "procedure name", "The name of the procedure to be used for saving", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("extensions", "extensions", "comma separated list of extensions this handler can save (i.e. \"jpg,jpeg\")", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE | GIMP_PARAM_NO_VALIDATE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("prefixes", "prefixes", "comma separated list of prefixes this handler can save (i.e. \"http:,ftp:\")", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE | GIMP_PARAM_NO_VALIDATE)); gimp_pdb_register_procedure (pdb, procedure); @@ -938,14 +938,14 @@ register_fileops_procs (GimpPDB *pdb) gimp_param_spec_string ("procedure-name", "procedure name", "The name of the procedure to associate a MIME type with.", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("mime-type", "mime type", "A single MIME type, like for example \"image/jpeg\".", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -968,14 +968,14 @@ register_fileops_procs (GimpPDB *pdb) gimp_param_spec_string ("load-proc", "load proc", "The name of the procedure the thumbnail loader with.", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("thumb-proc", "thumb proc", "The name of the thumbnail load procedure.", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); Index: app/pdb/font_select_cmds.c =================================================================== --- app/pdb/font_select_cmds.c (revision 22322) +++ app/pdb/font_select_cmds.c (working copy) @@ -133,21 +133,21 @@ register_font_select_procs (GimpPDB *pdb gimp_param_spec_string ("font-callback", "font callback", "The callback PDB proc to call when font selection is made", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("popup-title", "popup title", "Title of the font selection dialog", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("initial-font", "initial font", "The name of the font to set as the first selected", - FALSE, TRUE, + FALSE, TRUE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -170,7 +170,7 @@ register_font_select_procs (GimpPDB *pdb gimp_param_spec_string ("font-callback", "font callback", "The name of the callback registered for this pop-up", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -193,14 +193,14 @@ register_font_select_procs (GimpPDB *pdb gimp_param_spec_string ("font-callback", "font callback", "The name of the callback registered for this pop-up", - FALSE, FALSE, + FALSE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_procedure_add_argument (procedure, gimp_param_spec_string ("font-name", "font name", "The name of the font to set as selected", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); Index: app/pdb/procedural_db_cmds.c =================================================================== --- app/pdb/procedural_db_cmds.c (revision 22322) +++ app/pdb/procedural_db_cmds.c (working copy) @@ -431,7 +431,7 @@ register_procedural_db_procs (GimpPDB *p gimp_param_spec_string ("temp-name", "temp name", "A unique temporary name for a temporary PDB entry", - FALSE, FALSE, + FALSE, FALSE, FALSE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_register_procedure (pdb, procedure); @@ -454,7 +454,7 @@ register_procedural_db_procs (GimpPDB *p gimp_param_spec_string ("filename", "filename", "The dump filename", - TRUE, FALSE, + TRUE, FALSE, TRUE, NULL, GIMP_PARAM_READWRITE)); gimp_pdb_regi